Add execution_role_arn setting for two-role EB Scheduler model#2109
Merged
riysaxen-amzn merged 1 commit intoopensearch-project:mainfrom Apr 29, 2026
Merged
Conversation
riysaxen-amzn
requested review from
AWSHurneyt,
KashKondaka,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
lezzago,
manaswini1920,
nishtham-amazon,
rishabhmaurya,
toepkerd and
vikhy-aws
as code owners
engechas
approved these changes
Apr 28, 2026
eirsep
reviewed
Apr 29, 2026
| return Target.builder() | ||
| .arn(EB_SQS_UNIVERSAL_TARGET_ARN) | ||
| .roleArn(routing.roleArn) | ||
| .roleArn(routing.executionRoleArn ?: routing.roleArn) |
eirsep
approved these changes
Apr 29, 2026
eirsep
reviewed
Apr 29, 2026
| Setting.Property.NodeScope, Setting.Property.Dynamic | ||
| ) | ||
|
|
||
| /** IAM role ARN that EventBridge Scheduler assumes at fire time (Target.roleArn). Falls back to role_arn if blank. */ |
Member
There was a problem hiding this comment.
why do we need a fall back. why can't we mandate the setting?
riysaxen-amzn
force-pushed
the
feature/eb-scheduler-crud
branch
from
4865235 to
385d9f4
Compare
Add a separate execution_role_arn setting that specifies the IAM role EventBridge Scheduler assumes at fire time (Target.roleArn). Both role_arn and execution_role_arn are required when external scheduler is enabled — resolve() returns null (skipping EB operations) if either is blank. Signed-off-by: Riya Saxena <riysaxen@amazon.com>
riysaxen-amzn
force-pushed
the
feature/eb-scheduler-crud
branch
from
385d9f4 to
3035e12
Compare
riysaxen-amzn
merged commit 7851bf8
into
opensearch-project:main
16 of 23 checks passed
Collaborator
Author
|
Multi node tests were failing due to this flaky test failure Mentioning the -> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a separate execution_role_arn setting that specifies the IAM role EventBridge Scheduler assumes when a schedule fires (Target.roleArn). This enables a two-role security model where:
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.